Add collapsible component wrapper for Base UI#28
Closed
devin-ai-integration[bot] wants to merge 7 commits intomainfrom
Closed
Add collapsible component wrapper for Base UI#28devin-ai-integration[bot] wants to merge 7 commits intomainfrom
devin-ai-integration[bot] wants to merge 7 commits intomainfrom
Conversation
- Implement CollapsibleRoot, CollapsibleTrigger, CollapsiblePanel components - Add HighLevelCollapsible wrapper with trigger and content props - Follow existing component patterns from dialog and menu components - Add to lazy loading system in __init__.py - Include component in demo app for testing - All pre-commit hooks pass (ruff, codespell, pyright) Co-Authored-By: Carlos Cutillas <carlos@reflex.dev>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
- Remove unused Literal import from collapsible.py - Remove unused Any and Literal imports from collapsible.pyi - Fixes pre-commit check failures in CI Co-Authored-By: Carlos Cutillas <carlos@reflex.dev>
- Apply ruff format changes to collapsible.py and collapsible.pyi - Ensures all pre-commit hooks pass Co-Authored-By: Carlos Cutillas <carlos@reflex.dev>
- Remove class_name prop declaration from CollapsiblePanel - class_name is already inherited from BaseUIComponent - Fixes 'overrides a field of the same name but is missing a default value' error Co-Authored-By: Carlos Cutillas <carlos@reflex.dev>
- Add proper Base UI transition classes to PANEL with data-[ending-style]:h-0 data-[starting-style]:h-0 - Update demo to match Base UI example with chevron icon and recovery keys styling - Component tested successfully in browser with smooth transitions and event handling - Follows official Base UI collapsible example pattern Co-Authored-By: Carlos Cutillas <carlos@reflex.dev>
- Add descriptions sourced from Base UI GitHub repository - Update both .py and .pyi files for consistency - Descriptions explain browser search functionality and DOM mounting behavior Co-Authored-By: Carlos Cutillas <carlos@reflex.dev>
- Complete prop descriptions for CollapsiblePanel class - Both hidden_until_found and keep_mounted now have descriptions from Base UI docs - Ensures consistency between .py and .pyi files Co-Authored-By: Carlos Cutillas <carlos@reflex.dev>
Contributor
Author
|
Closing due to inactivity for more than 7 days. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add prop descriptions for CollapsiblePanel hidden_until_found and keep_mounted
Summary
Added missing prop descriptions for
hidden_until_foundandkeep_mountedproperties in theCollapsiblePanelclass. The descriptions were sourced directly from the official Base UI GitHub repository to ensure accuracy and consistency with the upstream component documentation.Changes:
hidden_until_found: Explains browser's built-in page search functionality andhidden="until-found"behaviorkeep_mounted: Explains DOM mounting behavior when panel is hidden.pyand.pyifiles for consistencyReview & Testing Checklist for Human
Diagram
%%{ init : { "theme" : "default" }}%% graph TD A["reflex_ui/components/base/collapsible.py"]:::major-edit B["reflex_ui/components/base/collapsible.pyi"]:::major-edit C["CollapsiblePanel class"]:::context D["hidden_until_found prop"]:::context E["keep_mounted prop"]:::context F["Base UI GitHub repo"]:::context A --> C B --> C C --> D C --> E F --> |"sourced descriptions"| D F --> |"sourced descriptions"| E subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes